Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Issue with point region doesn't work in Firefox #2727

Merged
merged 4 commits into from
Feb 2, 2021
Merged

Fixed: Issue with point region doesn't work in Firefox #2727

merged 4 commits into from
Feb 2, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 27, 2021 •
edited
Loading

Motivation and context

This one is probably browser issue, not CVAT.
If width or height of a SVG rectangle are 0, than getBBox() returns all 0 (even for x1, x2 which are actually not 0 according to current element attributes). Chrome works correct in this case, Firefox doesn't. Workaround-ed.

Resolved #2633

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Hi @dvkruchinin , do we have tests that creates issue by one tab on the canvas?

@bsekachev bsekachev added bug Something isn't working need test labels Jan 27, 2021
@bsekachev bsekachev requested a review from ActiveChooN January 27, 2021 16:50
@coveralls
Copy link

coveralls commented Jan 27, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 70.315% when pulling 5d5475e on bs/fixed_issue_2633 into 0380460 on develop.

@dvkruchinin
Copy link
Contributor

Hi @bsekachev

do we have tests that creates issue by one tab on the canvas?

Yes, there is a test tests\cypress\integration\actions_users\issue_2524_issue_not_reset_after_change_task.js. I will add the issue creation as a point to it.

@bsekachev bsekachev requested a review from nmanovic as a code owner January 28, 2021 10:37
@bsekachev bsekachev merged commit 789d6dd into develop Feb 2, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2633 branch February 2, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ActiveChooN ActiveChooN Awaiting requested review from ActiveChooN

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with point region doesn't work in Firefox
3 participants
@bsekachev @coveralls @dvkruchinin